« Welcome to Window Snyder! | Main | At FOSDEM this weekend »
December 8, 2006
Acid2!
This morning DBaron checked the reflow branch into the trunk. This is a pretty major step forward for the layout engine that will ship in Firefox3. In David's words the goals of the reflow refactoring are:
* simplification of code
* fixing incremental reflow ("{inc}") bugs
* fixing intrinsic sizing bugs
* allowing better integration of nsIBox and nsIFrame layout
* allowing easier implementation of new features like 'inline-block'
This also means the current trunk passes Acid2:
This is the reference image:
And - here's how Firefox2 fares:
Big congrats to David for all the hard work here - not to mention Bz for doing the reviews and a ton of other folks who helped test, review, setup tinderboxes, etc. In case you are wondering - he's what marking a bug of this magnitude fixed looks like:
Posted by schrep at December 8, 2006 6:30 PM
Comments
Whooboy, that's something to see.
Posted by: Eric Shepherd at December 8, 2006 10:07 PM
A hearty congratulations!
I noticed how damn quick the wiki articles http://en.wikipedia.org/wiki/Acid2 and http://en.wikipedia.org/wiki/Features_of_Mozilla_Firefox were changed :)
Posted by: wikireader at December 8, 2006 10:14 PM
That's just awesome :) Good work, people!
Posted by: Fred at December 8, 2006 11:35 PM
Good news! Great work!!
The position of the nose is slightly (about 1px) off. To see it, quickly tab forward and backward between both the reference image and trunk's rendering.
Posted by: veeven at December 9, 2006 5:39 AM
Yeah...
it's one pixel right and one pixel down.
But, anyway, I'm too happy to bother.
This 1px problem probably is simple to fix.
Posted by: Asrail at December 9, 2006 5:42 PM
nice work
hope it will be integrated in FF!!!
Posted by: gugast at December 11, 2006 6:50 AM
The issue with the nose looks similar to: http://weblog.timaltman.com/node/802
Posted by: Kevin at December 11, 2006 11:06 AM
It's OK for the position of the nose to be slightly different than in the reference rendering. IIRC, this is because the exact "position" of the nose is due to the order in which borders are drawn, which isn't specified by CSS.
Posted by: Jesse Ruderman at December 13, 2006 4:29 AM
Congratulations! Stuff like this is why it's so fun to use Minefield Trunk builds. ;)
Posted by: Tom 7 at January 3, 2007 11:37 AM
great work! so this will solve some bugs that are open since 2002 (5 years!) such as issues like
Splitting Absolutely positioned frames not implemented - Missing second page of content when printing or print previewing this site
https://bugzilla.mozilla.org/show_bug.cgi?id=154892
?
sounds like the community are really wanting basic features like printing to work correctly
Posted by: leigh at March 9, 2007 9:37 PM