October 8, 2003

Camino Review

Asa has set up some new flags on Camino product bugs to make it easier to implement this new process. I think it will help us get rolling quickly. I've already landed a couple of patches, and now that the tree is open for 1.6 development, we can get some of the lingering mozilla patches in (like the patch for slow history we had on the branch).

Here's my plan:


  1. When a patch is ready to begin the process, someone (the developer?) should set the review? flag. You do not have to specify a requestee.
  2. When the first reviewer has looked over and tested the patch to their satisfaction, they change the flag to review+. This will automatically create another, empty, review flag which the reviewer should, as before, set to review?.
  3. When the second review is complete, they should plus the bug and then set the superreview? flag which will email me and alert me that this bug is ready to land.
  4. The approval1.5 flag is reserved for bugs that need drivers@mozilla.org approval. I can't imagine we'll have any.

So this begs the question: how do we know what patches need review? There's a query which lists all Camino bugs with pending reviews. This is the place to start for those interested in performing reviews. It also lists pending superreviews so you can keep track of where I'm slacking.

Anyone who wants to take part in the review process should read the guidelines on mozilla.org, and especially the documents on style guide and reviewer's guide.

Posted by pinkerton at October 8, 2003 9:41 PM