Three Monkeys, Three Typewriters, Two Days

July 17, 2003

The wonderful world of ifdefs

I was poking about in webshell today, and discovered some fun |#ifdef MOZ_THUNDERBIRD| code that was checked in without anyone who could claim to be a webshell owner being consulted, as far as I can tell. Quite apart from the abysmal record Mozilla (and mail in particular) have as far as removing such "temporary" code, I think that removing such ifdefs should be the number one priority of the Firebird and Thunderbird developers. If they need help, API changes, etc. to do so, they should let the relevant module owner know instead of tossing in ifdefs!

After all, the only way we'll ever get the various apps to share a GRE is if the GRE includes a core that they can all use as-is. If proper functioning of Thunderbird relies on HTTP loads being punted to the OS in the docshell/webshell, there is no way that it can share libdocshell with Firebird.

Posted by bzbarsky at July 17, 2003 12:11 PM