Three Monkeys, Three Typewriters, Two Days

July 17, 2003

The wonderful world of ifdefs

I was poking about in webshell today, and discovered some fun |#ifdef MOZ_THUNDERBIRD| code that was checked in without anyone who could claim to be a webshell owner being consulted, as far as I can tell. Quite apart from the abysmal record Mozilla (and mail in particular) have as far as removing such "temporary" code, I think that removing such ifdefs should be the number one priority of the Firebird and Thunderbird developers. If they need help, API changes, etc. to do so, they should let the relevant module owner know instead of tossing in ifdefs!

After all, the only way we'll ever get the various apps to share a GRE is if the GRE includes a core that they can all use as-is. If proper functioning of Thunderbird relies on HTTP loads being punted to the OS in the docshell/webshell, there is no way that it can share libdocshell with Firebird.

Posted by bzbarsky at 12:11 PM

July 12, 2003


There are few things I find quite as annoying recently as the rampant fanboyism that seems to be all the rage nowadays.

Posted by bzbarsky at 12:14 AM

July 8, 2003

Hixie was right

Hixie was wondering about browsers passing his evil test of doom. With the patch in bug 212133 a current trunk Mozilla passes it with slithering green colors.

Posted by bzbarsky at 11:58 PM

July 4, 2003

Testing, testing....

Tried Safari on a friend's computer today, and I hope hyatt still wants to hear about web page display issues....

In particular, I tried out Safari on some testcases I've written over the last few years. It looks like there is no support for getComputedStyle() at all. The @charset tests all seem to fail. Something in the test of dynamic rule creation with @charset rules crashes the browser.

On the bright side, it did a pretty good job on the pure CSS testcases, and passed most of the dynamic inline style change tests; it failed the ones that involved setting .cssText.

Posted by bzbarsky at 8:49 PM