So far, we've run across only one extension, DictionarySearch, that's broken in our latest 1.0.3 nightly builds. Since I'm no JavaScript expert (or even amateur) I'm going to be working with others to put together a small technote on how to avoid the problem that's breaking DictonarySearch.
Until we get that written, you can check out Brendan's comment in the bug which explains the change we made and how you, as an extension author, should handle that change.
I'm hopeful that the number of extensions using this hack is small (we haven't heard of any others, yet) so the impact on end users should be minimal. If you know of other extensions that are using this hack, they're likely to be broken as well. If you know the author, it would be great if you could point them at this bug. If you are an extension author and you're doing something like this in your extension, it would be great if you could update your extension so that 1.0.3 users can fix themselves with an extension update.
So far, we don't see any other categories of breakage in extensions with the 1.0.3 builds. If you know of any, please let me know. Thanks.
update: if you do want to let me know about something not working, please include important information like which build you're testing on and on which platform. The version of the extension and any JavaScript console errors (be sure to set the javascript.options.showInConsole pref to true) you see with the extension, etc., etc. Thanks.
Posted by asa at April 13, 2005 01:28 PMWhat is the latest build of 1.0.3 that you are refering to?
Is it Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050408 Firefox/1.0.3
Posted by: Jay MacLean on April 13, 2005 02:21 PMSo will app.extensions.version be increased for this build?
Posted by: Matthew Wilson on April 13, 2005 02:25 PMThis is the latest
Posted by: Da Dude on April 13, 2005 03:19 PMThanks Da Dude, upgraded and looking for errors :-)
Posted by: Jay MacLean on April 13, 2005 03:32 PMThe following extensions give me a JS error (besides DictionarySearch):
Translation Panel 1.4.13.0.1:
Error: document.getElementById("popupMenuExchange") has no properties
Source File: chrome://translation/content/popup.js
Line: 50
ViewSourceWith 0.0.6:
Error: gViewSourceWithMain is not defined
Source File: chrome://viewsourcewith/content/viewsourcewithOverlay.js
Line: 297
Browse Images 0.2:
Error: content has no properties
Source File: chrome://browseimages/content/browseImagesOverlay.js
Line: 169
Also had this one (don't think this is a extension):
Error: this.docShell has no properties
Source File: chrome://global/content/bindings/browser.xml
Line: 0
Using:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.7) Gecko/20050412 Firefox/1.0.3
Windows 2000 build 2195 (SP4)
2 More
Have no idea:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://browser/content/browser.js :: Shutdown :: line 832" data: no]
AutoLogin 0.2:
Error: e.originalTarget.location has no properties
Source File: chrome://autologin/content/autologin.js
Line: 37
Actually I've seen that trick used in quite a few extensions (I remember QuickNote)... Will the app.extensions.version bumped?
Posted by: asqueella on April 13, 2005 03:52 PMDa Dude, are the extensions where you're seeing those errors not working? Were they working in 1.0.2?
asqueella, I don't believe we'll be bumping the app.extension.version for this release.
- A
Posted by: Asa Dotzler on April 13, 2005 04:40 PMDictionarySearch was working for me in the ZIP from the same directory as the W32 1.0.3 RC installer mentioned in the April 8 post, but I do confirm that its broken in the latest ZIP.
So... does that mean the April 8 RC is not going to be used? Also, is DS going to be updated in time for the release of 1.0.3? I use it a lot...
Posted by: Limulus on April 13, 2005 08:10 PM"Mozilla Firefox Icon is Windowing System's Standard Icon (Taskbar & Upper Lefthand Corner of App)"
https://bugzilla.mozilla.org/show_bug.cgi?id=171349
https://bugzilla.mozilla.org/show_bug.cgi?id=171349#c184
Asa is there indeed a patch checkin for 1.0.3 aviary, or is this just on Trunk?
Thanks.
Posted by: James on April 13, 2005 11:51 PMCan't you include a hack to make this still work in 1.0.3?
Posted by: Anonymous on April 14, 2005 12:34 AMSo, what's the point of app.extensions.version if it isn't altered when an incompatible change is made to the browser?
Posted by: Matthew Wilson on April 14, 2005 12:49 AM@Asa Dotzler, Yes they are working (besides dictionary), just seeying those errors.
Posted by: Da Dude on April 14, 2005 01:55 AMJust as a heads up, a few functions in Googlebar Lite will fail as a result of this bug. I have already fixed it (using the XPCNativeWrapper fix suggested in the bug), and the fix will appear in Googlebar Lite 0.9.1.
Posted by: Jonah Bishop on April 14, 2005 07:43 AMOops. Scratch my previous comment about Googlebar Lite. I'm going to wait for the 1.0.3 official build before I check for broken code in my extension.
Posted by: Jonah Bishop on April 14, 2005 08:03 AMHello:
I recently outlined how Spellbound 0.7.3 fails to work on the newest verseion of 1.0.3.
I obtained the version at "http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2005-04-13-01-aviary1.0.1/firefox-1.0.3.en-US.win32.installer.exe"
... re-installed the spellbound dictionaries. Results are still the same; it doesn't work.
HTH,
Lawrence
Posted by: Lawrence on April 14, 2005 08:57 AMAsa, please read http://forums.mozillazine.org/viewtopic.php?p=1385490#1385490
Posted by: Anonymous on April 14, 2005 09:03 AMJonah, what specific errors are you seeing? You may not need to use XPCNativeWrapper.
- A
Posted by: Asa Dotzler on April 14, 2005 03:56 PMAnonymous, I have no idea what kind of comment you're looking for.
- A
Posted by: Asa Dotzler on April 14, 2005 03:56 PMLawrence, what errors is spellbound giving in the JS console?
- A
Posted by: Asa Dotzler on April 14, 2005 03:57 PMon 1.0.3 nigtly,text/plain doesn't work.
but no javascript errors.
http://mozilla.durys.net/textplain/
Does anyone have time to and can anyone fix DictionarySearch? I tried to myself, but it won't install. Says the install script is missing.
Posted by: Peng on April 15, 2005 11:01 AMOh, never mind.
Posted by: Peng on April 15, 2005 11:07 AMLawrence - take a look at the spellbound faq
http://spellbound.sourceforge.net/faq#q601
I have also added notes to this affect on the home page
Posted by: Robert Strong on April 15, 2005 07:03 PMFiretune seems to work just fine on Firefox 1.0.3 :-)
Posted by: Mung on April 16, 2005 07:44 AMI have made a fix for Dictionary Search
Read (do it your self method) at:
http://forums.mozillazine.org/viewtopic.php?p=1392171#1392171
or download the fix at
http://home19.inet.tele.dk/henrik_jensen/files/dictionarysearch_0.8_FF103_fix.xpi
I'll remove the fix as soon as an updated version of Dictionary Search has been made.
Henrik
Posted by: Henrik Jensen on April 16, 2005 02:58 PM